netdev - Re: [Xen-devel] [PATCH] xen-netfront: prefer xenbus_write() over xenbus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 07 Jul 2016 06:05:31 -0600
From:	"Jan Beulich" <JBeulich@...e.com>
To:	<boris.ostrovsky@...cle.com>
Cc:	<david.vrabel@...rix.com>,
	"xen-devel" <xen-devel@...ts.xenproject.org>,
	"Juergen Gross" <JGross@...e.com>, <netdev@...r.kernel.org>
Subject: Re: [Xen-devel] [PATCH] xen-netfront: prefer xenbus_write()
 over xenbus_printf() where possible

>>> On 07.07.16 at 13:12, <david.vrabel@...rix.com> wrote:
> The better clean-up is to remove xenbus_write() in favour of
> xenbus_printf() everywhere (especially since one of your "cleanups" made
> it worse).

I don't think I've seen any reply indicating something has got made
worse. The fact that in one case I left the xenbus_printf() in place
despite having replaced the format string by one without %
specifier didn't result in a bug at all.

> xenbus_printf() does everything xenbus_write() can do with no loss of
> readability.

Yet with quite a bit higher overhead. Readability is not the point here.

Jan