netdev - Re: [PATCH net-next] ipv6: do not abuse GFP_ATOMIC in inet6_netconf_notify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <577F5D24.3060307@6wind.com>
Date:	Fri, 8 Jul 2016 09:58:28 +0200
From:	Nicolas Dichtel <nicolas.dichtel@...nd.com>
To:	Eric Dumazet <eric.dumazet@...il.com>,
	Masashi Honma <masashi.honma@...il.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] ipv6: do not abuse GFP_ATOMIC in
 inet6_netconf_notify_devconf()

Le 08/07/2016 05:46, Eric Dumazet a écrit :
> From: Eric Dumazet <edumazet@...gle.com>
> 
> All inet6_netconf_notify_devconf() callers are in process context,
> so we can use GFP_KERNEL allocations if we take care of not holding
> a rwlock while not needed in ip6mr (we hold RTNL there)
> 
> 
> Fixes: d67b8c616b48 ("netconf: advertise mc_forwarding status")
> Fixes: f3a1bfb11ccb ("rtnl/ipv6: use netconf msg to advertise forwarding status")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Nicolas Dichtel <nicolas.dichtel@...nd.com>
Acked-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>

Also nice, thanks.