netdev - Re: [RFC 0/7] netlink: Add allocation flag to netlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <578074F0.9030809@gmail.com>
Date:	Sat, 9 Jul 2016 12:52:16 +0900
From:	Masashi Honma <masashi.honma@...il.com>
To:	David Teigland <teigland@...hat.com>
Cc:	netdev@...r.kernel.org, netfilter-devel@...r.kernel.org,
	linux-wireless@...r.kernel.org, linux-rdma@...r.kernel.org,
	linux-audit@...hat.com, cluster-devel@...hat.com,
	johannes@...solutions.net, pablo@...filter.org, kaber@...sh.net,
	kadlec@...ckhole.kfki.hu, dledford@...hat.com,
	sean.hefty@...el.com, hal.rosenstock@...il.com,
	paul@...l-moore.com, eparis@...hat.com, zbr@...emap.net,
	pshelar@...ira.com, ccaulfie@...hat.com, bsingharora@...il.com
Subject: Re: [RFC 0/7] netlink: Add allocation flag to netlink_unicast()

On 2016年07月09日 01:08, David Teigland wrote:
> On Thu, Jul 07, 2016 at 09:35:45AM +0900, Masashi Honma wrote:
>> At the fs/dlm/netlink.c#dlm_timeout_warn(),
>> prepare_data allocates buffer with GFP_NOFS
>> and send_data() sends the buffer.
>>
>> But send_data() uses GFP_KERNEL or GFP_ATOMIC inside it.
>> Should it be replaced by GFP_NOFS ?
> That's old code that's never been used so it doesn't really matter.
>
I see. Thank you.