netdev - Re: [PATCH net-next] tun: Don't assume type tun in tun_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160708.235920.2218047996694463218.davem@davemloft.net>
Date:	Fri, 08 Jul 2016 23:59:20 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	kraigatgoog@...il.com
Cc:	netdev@...r.kernel.org, jasowang@...hat.com
Subject: Re: [PATCH net-next] tun: Don't assume type tun in tun_device_event

From: Craig Gallek <kraigatgoog@...il.com>
Date: Wed,  6 Jul 2016 18:44:20 -0400

> From: Craig Gallek <kraig@...gle.com>
> 
> The referenced change added a netlink notifier for processing
> device queue size events.  These events are fired for all devices
> but the registered callback assumed they only occurred for tun
> devices.  This fix adds a check (borrowed from macvtap.c) to discard
> non-tun device events.
> 
> For reference, this fixes the following splat:
 ...
> Fixes: 1576d9860599 ("tun: switch to use skb array for tx")
> Signed-off-by: Craig Gallek <kraig@...gle.com>

Applied, thanks.