netdev - Re: [PATCH -next] hfsc: reduce hfsc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160708.230901.2033851388253631522.davem@davemloft.net>
Date:	Fri, 08 Jul 2016 23:09:01 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	fw@...len.de
Cc:	netdev@...r.kernel.org, soltys@....info
Subject: Re: [PATCH -next] hfsc: reduce hfsc_sched to 14 cachelines

From: Florian Westphal <fw@...len.de>
Date: Mon,  4 Jul 2016 16:22:20 +0200

> hfsc_sched is huge (size: 920, cachelines: 15), but we can get it to 14
> cachelines by placing level after filter_cnt (covering 4 byte hole) and
> reducing period/nactive/flags to u32 (period is just a counter,
> incremented when class becomes active -- 2**32 is plenty for this
> purpose, also, long is only 32bit wide on 32bit platforms anyway).
> 
> cl_vtperiod is exported to userspace via tc_hfsc_stats, but its period
> member is already u32, so no precision is lost there either.
> 
> Cc: Michal Soltys <soltys@....info>
> Signed-off-by: Florian Westphal <fw@...len.de>

Applied, thanks.