netdev - Re: [PATCH net-next] ipv4: do not abuse GFP_ATOMIC in inet_netconf_notify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160709.181250.807452024075273359.davem@davemloft.net>
Date:	Sat, 09 Jul 2016 18:12:50 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	masashi.honma@...il.com, netdev@...r.kernel.org,
	nicolas.dichtel@...nd.com
Subject: Re: [PATCH net-next] ipv4: do not abuse GFP_ATOMIC in
 inet_netconf_notify_devconf()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Fri, 08 Jul 2016 05:18:24 +0200

> From: Eric Dumazet <edumazet@...gle.com>
> 
> inet_forward_change() runs with RTNL held.
> We are allowed to sleep if required.
> 
> If we use __in_dev_get_rtnl() instead of __in_dev_get_rcu(),
> we no longer have to use GFP_ATOMIC allocations in
> inet_netconf_notify_devconf(), meaning we are less likely to miss
> notifications under memory pressure, and wont touch precious memory
> reserves either and risk dropping incoming packets.
> 
> inet_netconf_get_devconf() can also use GFP_KERNEL allocation.
> 
> Fixes: edc9e748934c ("rtnl/ipv4: use netconf msg to advertise forwarding status")
> Fixes: 9e5511106f99 ("rtnl/ipv4: add support of RTM_GETNETCONF")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Nicolas Dichtel <nicolas.dichtel@...nd.com>

Applied.