netdev - Re: [PATCH net] dccp: avoid deadlock in dccp_v4_ctl_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160709.181507.1107002266440808218.davem@davemloft.net>
Date:	Sat, 09 Jul 2016 18:15:07 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	dvyukov@...gle.com, dccp@...r.kernel.org, gerrit@....abdn.ac.uk,
	netdev@...r.kernel.org, edumazet@...gle.com
Subject: Re: [PATCH net] dccp: avoid deadlock in dccp_v4_ctl_send_reset

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Fri, 08 Jul 2016 11:03:57 +0200

> From: Eric Dumazet <edumazet@...gle.com>
> 
> In the prep work I did before enabling BH while handling socket backlog,
> I missed two points in DCCP :
> 
> 1) dccp_v4_ctl_send_reset() uses bh_lock_sock(), assuming BH were
> blocked. It is not anymore always true.
> 
> 2) dccp_v4_route_skb() was using __IP_INC_STATS() instead of
>   IP_INC_STATS()
> 
> A similar fix was done for TCP, in commit 47dcc20a39d0
> ("ipv4: tcp: ip_send_unicast_reply() is not BH safe")
> 
> Fixes: 7309f8821fd6 ("dccp: do not assume DCCP code is non preemptible")
> Fixes: 5413d1babe8f ("net: do not block BH while processing socket backlog")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: Dmitry Vyukov <dvyukov@...gle.com>

Applied and queued up for -stable, thanks.