netdev - RE: [PATCH net-next 1/4] net/mlx4_core: Fix QUERY FUNC CAP flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 10 Jul 2016 09:30:52 +0000
From:	Moshe Shemesh <moshe@...lanox.com>
To:	Or Gerlitz <gerlitz.or@...il.com>,
	Tariq Toukan <tariqt@...lanox.com>
CC:	"David S. Miller" <davem@...emloft.net>,
	Linux Netdev List <netdev@...r.kernel.org>,
	Eran Ben Elisha <eranbe@...lanox.com>,
	"Hadar Hen Zion" <hadarh@...lanox.com>
Subject: RE: [PATCH net-next 1/4] net/mlx4_core: Fix QUERY FUNC CAP flags

>On Wed, Jul 6, 2016 at 3:29 PM, Tariq Toukan <tariqt@...lanox.com> wrote:
>> From: Moshe Shemesh <moshe@...lanox.com>
>>
>> Separate QUERY_FUNC_CAP flags0 from QUERY_FUNC_CAP flags.
>> Remove QUERY_FUNC_CAP port_flags field which was not in use.
>
>The patch title says "Fix ..." but the change log doesn't say if this is fixing real bug, or cleaning up dead >code, nor you point to the commit you are fixing, please add that, I guess it is something we do wrong >w.r.t the PHV bit but I am not clear what.

Both dead code and a bug:
One part is removing dead code (unused field - port_flags).
"Remove QUERY_FUNC_CAP port_flags field which was not in use." 

The other part is fixing a bug, as "flags" is already used for other set of flags in Func cap, while phv bit should be part of a different set of flags "flags0".
"Separate QUERY_FUNC_CAP flags0 from QUERY_FUNC_CAP flags." 

We will submit v2 with an updated commit massage including the relevant Fixes lines.

Regards,
Moshe.