netdev - RE: [PATCH net-next 4/4] net/mlx4_core: Add an option to configure SVLAN TPID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM4PR0501MB22288385E246DD0324E258EBD93E0@AM4PR0501MB2228.eurprd05.prod.outlook.com>
Date:	Sun, 10 Jul 2016 12:04:59 +0000
From:	Moshe Shemesh <moshe@...lanox.com>
To:	Or Gerlitz <gerlitz.or@...il.com>,
	Tariq Toukan <tariqt@...lanox.com>
CC:	"David S. Miller" <davem@...emloft.net>,
	Linux Netdev List <netdev@...r.kernel.org>,
	Eran Ben Elisha <eranbe@...lanox.com>,
	Ariel Almog <ariela@...lanox.com>
Subject: RE: [PATCH net-next 4/4] net/mlx4_core: Add an option to configure
 SVLAN TPID

>On Wed, Jul 6, 2016 at 3:29 PM, Tariq Toukan <tariqt@...lanox.com> wrote:
>> From: Moshe Shemesh <moshe@...lanox.com>
>>
>> Expose mlx4_config_svlan_tpid, that checks for feature support in 
>> device capabilities and sets the Service Tag TPID accordingly.
>
>I Googled for service tag TPID and I understand this is what we can vlan protcol, correct? any reason to >call it differently?

No, it is not the vlan protocol.
It is the ethertype used on the external vlan and the correct term is TPID.

> dead code? I don't see any invocation of this helper on the patch, if it's on earlier patches of the series it means you broke bisection...

I will recheck about that.

Regards,
Moshe.