netdev - Re: [PATCH net-next v2] tunnels: correct conditional build of MPLS and IPv6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160711.132733.449353383937689608.davem@davemloft.net>
Date:	Mon, 11 Jul 2016 13:27:33 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	simon.horman@...ronome.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2] tunnels: correct conditional build of MPLS
 and IPv6

From: Simon Horman <simon.horman@...ronome.com>
Date: Sun, 10 Jul 2016 10:20:11 +0900

> Using a combination if #if conditionals and goto labels to unwind
> tunnel4_init seems unwieldy. This patch takes a simpler approach of
> directly unregistering previously registered protocols when an error
> occurs.
> 
> This fixes a number of problems with the current implementation
> including the potential presence of labels when they are unused
> and the potential absence of unregister code when it is needed.
> 
> Fixes: 8afe97e5d416 ("tunnels: support MPLS over IPv4 tunnels")
> Signed-off-by: Simon Horman <simon.horman@...ronome.com>

Applied, thanks Simon.