netdev - Re: [PATCH net] sock: ignore SCM_RIGHTS and SCM_CREDENTIALS in __sock_cmsg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160711.133946.466146893193258126.davem@davemloft.net>
Date:	Mon, 11 Jul 2016 13:39:46 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	soheil.kdev@...il.com
Cc:	netdev@...r.kernel.org, slyfox@...too.org, soheil@...gle.com,
	edumazet@...gle.com, willemb@...gle.com
Subject: Re: [PATCH net] sock: ignore SCM_RIGHTS and SCM_CREDENTIALS in
 __sock_cmsg_send

From: Soheil Hassas Yeganeh <soheil.kdev@...il.com>
Date: Sun, 10 Jul 2016 12:51:46 -0400

> From: Soheil Hassas Yeganeh <soheil@...gle.com>
> 
> Sergei Trofimovich reported that pulse audio sends SCM_CREDENTIALS
> as a control message to TCP. Since __sock_cmsg_send does not
> support SCM_RIGHTS and SCM_CREDENTIALS, it returns an error and
> hence breaks pulse audio over TCP.
> 
> SCM_RIGHTS and SCM_CREDENTIALS are sent on the SOL_SOCKET layer
> but they semantically belong to SOL_UNIX. Since all
> cmsg-processing functions including sock_cmsg_send ignore control
> messages of other layers, it is best to ignore SCM_RIGHTS
> and SCM_CREDENTIALS for consistency (and also for fixing pulse
> audio over TCP).
> 
> Signed-off-by: Soheil Hassas Yeganeh <soheil@...gle.com>
> Reported-by: Sergei Trofimovich <slyfox@...too.org>
> Tested-by: Sergei Trofimovich <slyfox@...too.org>

Please resubmit this with a proper "Fixes: " tag which tells which
commit introduced this regression.