netdev - Re: [PATCH v7 00/11] Add driver bpf hook for early packet drop and forwarding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALx6S36=Cqtte2Eer0VF-_4ki7Z-xk_2jgw4xXCvRGLb7gGbxg@mail.gmail.com>
Date:	Mon, 11 Jul 2016 16:26:36 -0700
From:	Tom Herbert <tom@...bertland.com>
To:	Or Gerlitz <gerlitz.or@...il.com>
Cc:	Brenden Blanco <bblanco@...mgrid.com>,
	David Miller <davem@...emloft.net>,
	Linux Netdev List <netdev@...r.kernel.org>,
	Jamal Hadi Salim <jhs@...atatu.com>,
	Saeed Mahameed <saeedm@....mellanox.co.il>,
	Martin KaFai Lau <kafai@...com>,
	Jesper Dangaard Brouer <brouer@...hat.com>,
	Ari Saha <as754m@....com>,
	Alexei Starovoitov <alexei.starovoitov@...il.com>,
	john fastabend <john.fastabend@...il.com>,
	Hannes Frederic Sowa <hannes@...essinduktion.org>,
	Thomas Graf <tgraf@...g.ch>,
	Daniel Borkmann <daniel@...earbox.net>
Subject: Re: [PATCH v7 00/11] Add driver bpf hook for early packet drop and forwarding

On Mon, Jul 11, 2016 at 2:53 PM, Or Gerlitz <gerlitz.or@...il.com> wrote:
> On Tue, Jul 12, 2016 at 12:29 AM, Brenden Blanco <bblanco@...mgrid.com> wrote:
>
>> v7:
> [...]
>>  TODOs:
>>  Add ethtool per-ring stats for aborted, default cases, maybe even drop
>>  and tx as well.
>
> please no... lets stop and think if we can have something better vs
> every XDP enabled driver to have bunch of new ethtool based stats, was
> this somehow discussed over the threads so far?

We'll also need to consider statistics what statistics a device keeps
and how they are exposed when the device offloads XDP, and also the
possibility that the BPF program itself might keep its own stats.

Tom