netdev - Re: [patch net-next 1/2] devlink: add hardware messages tracing facility

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <74df1f22-1777-fa69-1a82-cb26388060b8@cumulusnetworks.com>
Date:	Mon, 11 Jul 2016 09:01:46 -0600
From:	David Ahern <dsa@...ulusnetworks.com>
To:	Jiri Pirko <jiri@...nulli.us>, netdev@...r.kernel.org
Cc:	davem@...emloft.net, idosch@...lanox.com, yotamg@...lanox.com,
	eladr@...lanox.com, nogahf@...lanox.com, ogerlitz@...lanox.com,
	ivecera@...hat.com, rostedt@...dmis.org, mingo@...hat.com,
	jolsa@...nel.org
Subject: Re: [patch net-next 1/2] devlink: add hardware messages tracing
 facility

On 7/11/16 7:18 AM, Jiri Pirko wrote:

> diff --git a/net/core/devlink.c b/net/core/devlink.c
> index b2e592a..8cfa3b0 100644
> --- a/net/core/devlink.c
> +++ b/net/core/devlink.c
> @@ -26,6 +26,8 @@
>  #include <net/net_namespace.h>
>  #include <net/sock.h>
>  #include <net/devlink.h>
> +#define CREATE_TRACE_POINTS
> +#include <trace/events/devlink.h>

EXPORT_TRACEPOINT_SYMBOL_GPL(trace_devlink_hwmsg);

>
>  static LIST_HEAD(devlink_list);
>
> @@ -1679,6 +1681,13 @@ void devlink_free(struct devlink *devlink)
>  }
>  EXPORT_SYMBOL_GPL(devlink_free);
>
> +void devlink_trace_hwmsg(const struct devlink *devlink, bool incoming,
> +			 unsigned long type, const u8 *buf, size_t len)
> +{
> +	trace_devlink_hwmsg(devlink, incoming, type, buf, len);
> +}
> +EXPORT_SYMBOL_GPL(devlink_trace_hwmsg);

Then you don't need this devlink function.