netdev - RE: [Intel-wired-lan] [PATCH] ixgbe: always initialize setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <87618083B2453E4A8714035B62D6799250670DA6@FMSMSX105.amr.corp.intel.com>
Date:	Mon, 11 Jul 2016 18:41:40 +0000
From:	"Tantilov, Emil S" <emil.s.tantilov@...el.com>
To:	Patrick McLean <patrickm@...kai.com>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
Subject: RE: [Intel-wired-lan] [PATCH] ixgbe: always initialize setup_fc

>-----Original Message-----
>From: Intel-wired-lan [mailto:intel-wired-lan-bounces@...ts.osuosl.org] On
>Behalf Of Patrick McLean
>Sent: Friday, July 01, 2016 6:31 PM
>To: Kirsher, Jeffrey T <jeffrey.t.kirsher@...el.com>
>Cc: netdev@...r.kernel.org; intel-wired-lan@...ts.osuosl.org
>Subject: [Intel-wired-lan] [PATCH] ixgbe: always initialize setup_fc
>
>In ixgbe_init_mac_link_ops_X550em, the code has a special case for
>backplane media type, but does not fall through to the default case, so the
>setup_fc never gets initialized. This causes a panic when it later tries to
>set up the card, and the kernel dereferences the null pointer.
>
>This patch lets the the function fall through, which initialized setup_fc
>properly.

Why are you resending this patch? I have already submitted a patch to handle this properly:
http://patchwork.ozlabs.org/patch/646228/

Thanks,
Emil