netdev - Re: [PATCH v7 04/11] net/mlx4_en: add support for fast rx drop bpf program

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160712163118.GA13865@gmail.com>
Date:	Tue, 12 Jul 2016 09:31:21 -0700
From:	Brenden Blanco <bblanco@...mgrid.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, jhs@...atatu.com,
	saeedm@....mellanox.co.il, kafai@...com, brouer@...hat.com,
	as754m@....com, alexei.starovoitov@...il.com, gerlitz.or@...il.com,
	john.fastabend@...il.com, hannes@...essinduktion.org,
	tgraf@...g.ch, tom@...bertland.com, daniel@...earbox.net
Subject: Re: [PATCH v7 04/11] net/mlx4_en: add support for fast rx drop bpf
 program

On Mon, Jul 11, 2016 at 11:17:00PM -0700, David Miller wrote:
> From: Brenden Blanco <bblanco@...mgrid.com>
> Date: Mon, 11 Jul 2016 14:29:51 -0700
> 
> > +	if (priv->num_frags > 1)
> > +		return -EOPNOTSUPP;
> 
> I hate to be the user who has to debug why his XDP program won't
> load just because he set a jumbo MTU beforehand.
Me too. Patch v8 now has an en_err message, and double checked that a
message is printed when MTU is attempted to be increased when XDP
program has already been loaded.

Thanks.