netdev - Re: [PATCH 1/1] bonding: restrict the data protected by rcu_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 12 Jul 2016 11:03:07 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	zyjzyj2000@...il.com
Cc:	netdev@...r.kernel.org, jay.vosburgh@...onical.com
Subject: Re: [PATCH 1/1] bonding: restrict the data protected by
 rcu_read_lock

From: Zhu Yanjun <zyjzyj2000@...il.com>
Date: Tue, 12 Jul 2016 15:28:17 +0800

> In this function, origin is a pointer to struct aggregator.
> No matter what agg is changed to, it has nothing to do with origin.
> 
> CC: Jay Vosburgh <jay.vosburgh@...onical.com>
> Signed-off-by: Zhu Yanjun <zyjzyj2000@...il.com>

I really hate changes like this.

Imagine if a inner function was called with RCU protection around
it, as a rule.

That's the same as what is happening here, the RCU locking is done
around the entire contents of the function and that is perfectly
fine even if one variable assignment or whatever is superfluously
contained inside of it.

I'm not applying this patch, sorry.