netdev - Re: [PATCH -next] ipv4: af_inet: make it explicitly non-modular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 11 Jul 2016 22:44:46 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	paul.gortmaker@...driver.com
Cc:	netdev@...r.kernel.org, kuznet@....inr.ac.ru, jmorris@...ei.org,
	yoshfuji@...ux-ipv6.org, kaber@...sh.net
Subject: Re: [PATCH -next] ipv4: af_inet: make it explicitly non-modular

From: Paul Gortmaker <paul.gortmaker@...driver.com>
Date: Mon, 11 Jul 2016 16:37:51 -0400

> The Makefile controlling compilation of this file is obj-y,
> meaning that it currently is never being built as a module.
> 
> Since MODULE_ALIAS is a no-op for non-modular code, we can simply
> remove the MODULE_ALIAS_NETPROTO variant used here.
> 
> We replace module.h with kmod.h since the file does make use of
> request_module() in order to load other modules from here.
> 
> We don't have to worry about init.h coming in via the removed
> module.h since the file explicitly includes init.h already.
> 
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Alexey Kuznetsov <kuznet@....inr.ac.ru>
> Cc: James Morris <jmorris@...ei.org>
> Cc: Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>
> Cc: Patrick McHardy <kaber@...sh.net>
> Cc: netdev@...r.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>

Applied to net-next, thanks.