lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 12 Jul 2016 11:14:43 +0300 From: Luca Coelho <luca@...lho.fi> To: Arnd Bergmann <arnd@...db.de>, Johannes Berg <johannes.berg@...el.com>, kvalo <kvalo@...eaurora.org> Cc: Emmanuel Grumbach <emmanuel.grumbach@...el.com>, Intel Linux Wireless <linuxwifi@...el.com>, Kalle Valo <kvalo@...eaurora.org>, Eliad Peller <eliad@...ery.com>, linux-wireless@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] iwlwifi: add missing type declaration On Mon, 2016-07-11 at 22:49 +0200, Arnd Bergmann wrote: > The iwl-debug.h header relies in implicit inclusion of linux/device.h > and > we get a lot of warnings without that: > > drivers/net/wireless/intel/iwlwifi/iwl-debug.h:44:23: error: 'struct > device' declared inside parameter list will not be visible outside of > this definition or declaration [-Werror] > void __iwl_err(struct device *dev, bool rfkill_prefix, bool > only_trace, > ^~~~~~ > In file included from drivers/net/wireless/intel/iwlwifi/iwl-eeprom- > read.h:66:0, > from drivers/net/wireless/intel/iwlwifi/iwl-eeprom- > read.c:68: > drivers/net/wireless/intel/iwlwifi/iwl-trans.h: In function > 'iwl_trans_tx': > drivers/net/wireless/intel/iwlwifi/iwl-trans.h:1030:348: error: > passing argument 1 of '__iwl_err' from incompatible pointer type [- > Werror=incompatible-pointer-types] > IWL_ERR(trans, "%s bad state = %d\n", __func__, trans->state); > > > > > > ^ > In file included from drivers/net/wireless/intel/iwlwifi/iwl-eeprom- > read.c:67:0: > drivers/net/wireless/intel/iwlwifi/iwl-debug.h:44:6: note: expected > 'struct device *' but argument is of type 'struct device *' > void __iwl_err(struct device *dev, bool rfkill_prefix, bool > only_trace, > ^~~~~~~~~ > > The easiest workaround is to just declare 'struct device' before its > first use, > rather than including the entire header file. > > Signed-off-by: Arnd Bergmann <arnd@...db.de> > Fixes: 21cb3222fe56 ("iwlwifi: decouple PCIe transport from > mac80211") > --- Acked-by: Luca Coelho <luciano.coelho@...el.com> Agree with Kalle that he will take this directly to wireless-drivers- next. -- Cheers, Luca.
Powered by blists - more mailing lists