netdev - Re: [patch v2] net/mlx5: missing error code in esw_create_offloads_fdb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <83288161-1577-4092-6d6d-125b219cedf9@mellanox.com>
Date:	Wed, 13 Jul 2016 16:17:05 +0300
From:	Matan Barak <matanb@...lanox.com>
To:	Leon Romanovsky <leonro@...lanox.com>,
	Dan Carpenter <dan.carpenter@...cle.com>
CC:	Or Gerlitz <ogerlitz@...lanox.com>, <netdev@...r.kernel.org>,
	<linux-rdma@...r.kernel.org>, <kernel-janitors@...r.kernel.org>
Subject: Re: [patch v2] net/mlx5: missing error code in
 esw_create_offloads_fdb_table()

On 13/07/2016 16:04, Leon Romanovsky wrote:
> On Wed, Jul 13, 2016 at 02:48:44PM +0300, Dan Carpenter wrote:
>> We accidentally return success when we had intended to return an error
>> code.
>>
>> Fixes: 69697b6e2086 ('net/mlx5: E-Switch, Add support for the sriov offloads mode')
>> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
>> ---
>> v2: return -ENOTSUPP instead --EINVAL
>
> I'm a little bit confused. Why did you prefer ENOTSUPP over EOPNOTSUPP?

According to [1], it fits our case better - operation is valid and make 
sense, but isn't supported.

[1] https://lists.gnu.org/archive/html/bug-glibc/2002-08/msg00017.html

>
> Thanks.
>