lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 13 Jul 2016 15:47:54 +0200 (CEST) From: Jiri Kosina <jikos@...nel.org> To: Cong Wang <xiyou.wangcong@...il.com> cc: Eric Dumazet <eric.dumazet@...il.com>, Jamal Hadi Salim <jhs@...atatu.com>, Phil Sutter <phil@....cc>, Linux Kernel Network Developers <netdev@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org> Subject: Re: [RFC PATCH v3] net: sched: convert qdisc linked list to hashtable On Tue, 12 Jul 2016, Cong Wang wrote: > > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > > index f45929c..0b5c172e 100644 > > --- a/include/linux/netdevice.h > > +++ b/include/linux/netdevice.h > > @@ -52,6 +52,7 @@ > > #include <uapi/linux/netdevice.h> > > #include <uapi/linux/if_bonding.h> > > #include <uapi/linux/pkt_cls.h> > > +#include <linux/hashtable.h> > > > > struct netpoll_info; > > struct device; > > @@ -1778,6 +1779,7 @@ struct net_device { > > unsigned int num_tx_queues; > > unsigned int real_num_tx_queues; > > struct Qdisc *qdisc; > > + DECLARE_HASHTABLE (qdisc_hash, 4); > > unsigned long tx_queue_len; > > spinlock_t tx_global_lock; > > int watchdog_timeo; > > Should it be surrounded by CONFIG_NET_SCHED? > To save several bytes for !CONFIG_NET_SCHED case. Makes sense. I'll wait a bit for more feedback (if there is any) before including this in potential v4. Thanks, -- Jiri Kosina SUSE Labs
Powered by blists - more mailing lists