netdev - Re: [PATCH] net: phy: micrel: Add KSZ8041FTL fiber mode support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1468507590.2260.49.camel@pengutronix.de>
Date:	Thu, 14 Jul 2016 16:46:30 +0200
From:	Philipp Zabel <p.zabel@...gutronix.de>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	netdev@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
	Mark Rutland <mark.rutland@....com>,
	Florian Fainelli <f.fainelli@...il.com>,
	devicetree@...r.kernel.org,
	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	Geert Uytterhoeven <geert@...ux-m68k.org>
Subject: Re: [PATCH] net: phy: micrel: Add KSZ8041FTL fiber mode support

Am Donnerstag, den 14.07.2016, 16:33 +0200 schrieb Arnd Bergmann:
> On Thursday, July 14, 2016 4:29:43 PM CEST Philipp Zabel wrote:
> > +
> > + - micrel,fiber-mode: If present the PHY is configured to operate in fiber mode
> > +
> > +       Some PHYs, such as the KSZ8041FTL variant, support fiber mode, enabled
> > +       by the FXEN boot strapping pin. It can't be determined from the PHY
> > +       registers whether the PHY is in fiber mode, so this boolean device tree
> > +       property can be used to describe it.
> > +
> > +       In fiber mode, auto-negotiation is disabled and the PHY can only work in
> > +       100base-fx (full and half duplex) modes.
> > 
> 
> Could the generic "phy-mode" property used for this, to avoid the need for
> definingn a custom property?

According to ethernet.txt, that property currently describes the
internal interface:

  - phy-mode: string, operation mode of the PHY interface; supported values are                                                                 
    "mii", "gmii", "sgmii", "qsgmii", "tbi", "rev-mii", "rmii", "rgmii", "rgmii-id",
    "rgmii-rxid", "rgmii-txid", "rtbi", "smii", "xgmii"; this is now a de-facto
    standard property;

In this case I have a phy-mode = "rmii" on the MAC. Wouldn't setting
phy-mode = "fiber" on the phy be confusing since for the internal
interface it should be "rmii"?

regards
Philipp