netdev - Re: [PATCH] net: phy: micrel: Add KSZ8041FTL fiber mode support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160714151305.GH6667@lunn.ch>
Date:	Thu, 14 Jul 2016 17:13:05 +0200
From:	Andrew Lunn <andrew@...n.ch>
To:	Philipp Zabel <p.zabel@...gutronix.de>
Cc:	netdev@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
	Mark Rutland <mark.rutland@....com>,
	Florian Fainelli <f.fainelli@...il.com>,
	devicetree@...r.kernel.org,
	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	Geert Uytterhoeven <geert@...ux-m68k.org>
Subject: Re: [PATCH] net: phy: micrel: Add KSZ8041FTL fiber mode support

> +static int ksz8041_config_init(struct phy_device *phydev)
> +{
> +	/* Limit supported and advertised modes in fiber mode */
> +	if (of_property_read_bool(phydev->mdio.dev.of_node, "fxen")) {
> +		phydev->dev_flags |= MICREL_PHY_FXEN;
> +		phydev->supported &= SUPPORTED_FIBRE |
> +				     SUPPORTED_100baseT_Full |
> +				     SUPPORTED_100baseT_Half;
> +		phydev->advertising &= ADVERTISED_FIBRE |
> +				       ADVERTISED_100baseT_Full |
> +				       ADVERTISED_100baseT_Half;

Hi Philipp

Does the PHY actually advertise anything? Should phydev->advertising
be set to 0?

   Andrew