netdev - Re: [PATCH net-next V3] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160714152215.GA24590@u54ee753d2d1854bda401.ant.amazon.com>
Date:	Thu, 14 Jul 2016 08:22:15 -0700
From:	Matt Wilson <msw@...n.com>
To:	Netanel Belgazal <netanel@...apurnalabs.com>,
	Benjamin Poirier <benjamin.poirier@...il.com>,
	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, davem@...emloft.net,
	linux-kernel@...r.kernel.org, zorik@...apurnalabs.com,
	saeed@...apurnalabs.com, alex@...apurnalabs.com,
	aliguori@...zon.com, ben@...adent.org.uk, romieu@...zoreil.com,
	rami.rosen@...el.com, antoine.tenart@...e-electrons.com
Subject: Re: [PATCH net-next V3] net: ena: Add a driver for Amazon Elastic
 Network Adapters (ENA)

On Thu, Jul 14, 2016 at 09:46:14AM +0300, Netanel Belgazal wrote:
> This is a driver for the ENA family of networking devices.
> 
> Signed-off-by: Netanel Belgazal <netanel@...apurnalabs.com>
> ---
> 
> Notes:
>     Changes in v3:
>     - Fix compilation warning for 32bit systems. [kbuild test rebot]
>     - Replace netdev->num_tx_queues with adapter->num_queues in ethtool. [ben@...adent.org.uk]
>     - Use get_link_ksettings instread of get_settings (deprecated ethtool API). [ben@...adent.org.uk]
>     - Remove rna_nway_reset (ethtool). [ben@...adent.org.uk]
>     - Add missing break in switch condition. [ben@...adent.org.uk]
>     - Increase driver version to 1.0.2
>     
>     Changes in v2:
>     - Increment driver version to 1.0.1
>     - Reorder the initialization of the workqueus and the timer service
>     - Initialize last_keep_alive_jiffies in probe
>     - Remove ena_trc_* functions in favor of pr_* [davem@...emloft.net]
>     - Fix Tx interrupt control register value [romieu@...zoreil.com]
>     - Edit ena.txt to focus on technical details [romieu@...zoreil.com]
>     - Rename small_copy_len tunable to rx_copybreak [benjamin.poirier@...il.com]
>     - Change uint32_t to u32 [romieu@...zoreil.com]
>     - Return error in ena_com_set_hash_ctrl [rami.rosen@...el.com]
>     - Fix API documentation [rami.rosen@...el.com]
>     - Remove redundant check in ena_com_mem_addr_set [romieu@...zoreil.com]
>     - Add local variables for allocation methods to improve readability [romieu@...zoreil.com]
>     - Replace dma_alloc_coherent and __GFP_ZERO flag with dma_zalloc_coherent [romieu@...zoreil.com]
>     - Fix style when using dma_alloc_coherent [romieu@...zoreil.com]
>     - Tx xmit - In case of an error drop the packet and return NETDEV_TX_OK [romieu@...zoreil.com]
>     - Reduce the number of parameters in ena_get_dev_stats [romieu@...zoreil.com]
>     - Return ret and not 0 in ena_com_set_hash_ctrl [rami.rosen@...el.com]
>     - Do not initialize variables if the function doesn't read them before the second write [romieu@...zoreil.com]
>     - Enums - Replace space with tabs to line the assign value [romieu@...zoreil.com]
>     - Remove redundant comments [romieu@...zoreil.com]
>     
>     TODO:
>     - Add bytes variable to set_coalesce ethtool callback and use this callback
>       instead of dedicated sysfs files.

Dave and Benjamin,

Do you want to see the interrupt moderation extensions to ethtool and
the sysfs nodes removed before this lands in net-next? Or should
Netanel remove the sysfs bits until we can extend the ethtool
interfaces to cover the parameters that ena uses?

--msw