netdev - Re: [patch net-next 2/2] devlink: fix trace format string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160714131829.36ae548b@gandalf.local.home>
Date:	Thu, 14 Jul 2016 13:18:29 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Randy Dunlap <rdunlap@...radead.org>
Cc:	Jiri Pirko <jiri@...nulli.us>, netdev@...r.kernel.org,
	davem@...emloft.net, arnd@...db.de, linux-kernel@...r.kernel.org,
	idosch@...lanox.com, yotamg@...lanox.com, eladr@...lanox.com,
	nogahf@...lanox.com, ogerlitz@...lanox.com, ivecera@...hat.com,
	mingo@...hat.com, jolsa@...nel.org
Subject: Re: [patch net-next 2/2] devlink: fix trace format string

On Thu, 14 Jul 2016 10:07:38 -0700
Randy Dunlap <rdunlap@...radead.org> wrote:

> On 07/14/16 02:37, Jiri Pirko wrote:
> > From: Arnd Bergmann <arnd@...db.de>
> > 
> > Including devlink.h on ARM and probably other 32-bit architectures results in
> > a harmless warning:
> > 
> > In file included from ../include/trace/define_trace.h:95:0,
> >                  from ../include/trace/events/devlink.h:51,
> >                  from ../net/core/devlink.c:30:
> > include/trace/events/devlink.h: In function 'trace_raw_output_devlink_hwmsg':
> > include/trace/events/devlink.h:42:12: error: format '%lu' expects argument of type 'long unsigned int', but argument 10 has type 'size_t {aka unsigned int}' [-Werror=format=]
> > 
> > The correct format string for 'size_t' is %zu, not %lu, this works on all
> > architectures.
> > 
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> > Fixes: e5224f0fe2ac ("devlink: add hardware messages tracing facility")
> > Signed-off-by: Jiri Pirko <jiri@...lanox.com>  
> 
> Acked-by: Randy Dunlap <rdunlap@...radead.org>
> 

ditto!

-- Steve