netdev - Re: [PATCH] bonding: set carrier off for devices created through netlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160714.161830.432143369745656151.davem@davemloft.net>
Date:	Thu, 14 Jul 2016 16:18:30 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	bgalvani@...hat.com
Cc:	netdev@...r.kernel.org, j.vosburgh@...il.com, vfalico@...il.com,
	gospo@...ulusnetworks.com, kernel@...uxace.com
Subject: Re: [PATCH] bonding: set carrier off for devices created through
 netlink

From: Beniamino Galvani <bgalvani@...hat.com>
Date: Wed, 13 Jul 2016 18:25:08 +0200

> Commit e826eafa65c6 ("bonding: Call netif_carrier_off after
> register_netdevice") moved netif_carrier_off() from bond_init() to
> bond_create(), but the latter is called only for initial default
> devices and ones created through sysfs:
> 
>  $ modprobe bonding
>  $ echo +bond1 > /sys/class/net/bonding_masters
>  $ ip link add bond2 type bond
>  $ grep "MII Status" /proc/net/bonding/*
>  /proc/net/bonding/bond0:MII Status: down
>  /proc/net/bonding/bond1:MII Status: down
>  /proc/net/bonding/bond2:MII Status: up
> 
> Ensure that carrier is initially off also for devices created through
> netlink.
> 
> Signed-off-by: Beniamino Galvani <bgalvani@...hat.com>

Applied and queued up for -stable, thanks.