netdev - Re: [PATCH] net: phy: micrel: Add KSZ8041FTL fiber mode support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d7474fed-89cb-1089-5b52-f8964cd7f840@cogentembedded.com>
Date:	Thu, 14 Jul 2016 14:35:59 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Philipp Zabel <p.zabel@...gutronix.de>, netdev@...r.kernel.org
Cc:	Rob Herring <robh+dt@...nel.org>,
	Mark Rutland <mark.rutland@....com>,
	Florian Fainelli <f.fainelli@...il.com>,
	devicetree@...r.kernel.org,
	Geert Uytterhoeven <geert@...ux-m68k.org>
Subject: Re: [PATCH] net: phy: micrel: Add KSZ8041FTL fiber mode support

Hello.

On 7/14/2016 1:18 PM, Philipp Zabel wrote:

> We can't detect the FXEN (fiber mode) bootstrap pin, so configure
> it via a boolean device tree property "fxen". If it is enabled,
> auto-negotiation is not supported. The only available modes are
> 100base-fx (full duplex and half duplex).
>
> Signed-off-by: Philipp Zabel <p.zabel@...gutronix.de>
> ---
> I didn't see a way to reliably detect whether the PHY is set to fiber
> mode in the datasheet [1], so this patch adds a device tree property
> to enforce fiber mode (disable auto-negotiation, set speed to 100).
>
> [1] http://ww1.microchip.com/downloads/en/DeviceDoc/ksz8041tl-ftl-mll.pdf
> ---
>  .../devicetree/bindings/net/micrel-ksz8041.txt     | 24 ++++++++++++++++
>  drivers/net/phy/micrel.c                           | 32 ++++++++++++++++++++--
>  include/linux/micrel_phy.h                         |  1 +
>  3 files changed, 55 insertions(+), 2 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/net/micrel-ksz8041.txt
>
> diff --git a/Documentation/devicetree/bindings/net/micrel-ksz8041.txt b/Documentation/devicetree/bindings/net/micrel-ksz8041.txt
> new file mode 100644
> index 0000000..4bce38d2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/micrel-ksz8041.txt

    I think your text should be added to micrel.txt instead.

> @@ -0,0 +1,24 @@
> +Micrel KSZ8041 Gigabit Ethernet PHY
> +
> +The KSZ8041FTL variant supports fiber mode, enabled by the FXEN boot
> +strapping pin. It can't be determined from the PHY registers whether
> +the PHY is in fiber mode, so a boolean device tree property can be
> +used to describe this.
> +
> +Optional properties:
> + - fxen : KSZ8041FTL is strapped to fiber mode. Auto-negotiation is disabled

    It should be named micrel,fxen.

[...]

MBR, Sergei