netdev - Re: [PATCH iproute2] ss: Fix support for device filter by index

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8fe8c4a4-6635-da65-0371-0c27239ce047@cumulusnetworks.com>
Date:	Fri, 15 Jul 2016 12:56:55 -0600
From:	David Ahern <dsa@...ulusnetworks.com>
To:	Stephen Hemminger <stephen@...workplumber.org>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH iproute2] ss: Fix support for device filter by index

On 7/15/16 12:53 PM, Stephen Hemminger wrote:
> On Fri, 15 Jul 2016 09:29:28 -0700
> David Ahern <dsa@...ulusnetworks.com> wrote:
>
>> Support was recently added for device filters. The intent was to allow
>> the device to be specified by name or index, and using the if%u format
>> (dev == if5) or the simpler and more intuitive index alone (dev == 5).
>> The latter case is broken since the index is not saved to the filter
>> after the strtoul conversion. Further, the tmp variable used for the
>> conversion shadows another variable used in the function. Fix both.
>>
>> With this change all 3 variants work as expected:
>> $ ss -t 'dev == 62'
>> State   Recv-Q Send-Q         Local Address:Port    Peer Address:Port
>> ESTAB       0      224         10.0.1.3%mgmt:ssh   192.168.0.50:58442
>>
>> $ ss -t 'dev == mgmt'
>> State   Recv-Q Send-Q         Local Address:Port    Peer Address:Port
>> ESTAB       0      224         10.0.1.3%mgmt:ssh   192.168.0.50:58442
>>
>> $ ss -t 'dev == if62'
>> State   Recv-Q Send-Q         Local Address:Port    Peer Address:Port
>> ESTAB       0      36          10.0.1.3%mgmt:ssh   192.168.0.50:58442
>>
>> Fixes: 2d2932125616 ("ss: Add support to filter on device")
>> Signed-off-by: David Ahern <dsa@...ulusnetworks.com>
>
> Won't apply to current code.
> Please rebase.
>

It applies cleanly for me to master branch. That's where the ss dev 
filter is from June:

commit 2d29321256168e13e10fbde3c57f33e70dcb6cc8
Author: David Ahern <dsa@...ulusnetworks.com>
Date:   Mon Jun 27 11:34:25 2016 -0700

     ss: Add support to filter on device

No commits on that file since except 
62000e51e05d635016bae9891a4e00134ed8aefb which does not impact the 
function in question.