netdev - Re: [PATCH 2/2] net: ethernet: amd: au1000_eth: use phy_ethtool_{get|set}_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160715.164413.2171292428501556413.davem@davemloft.net>
Date:	Fri, 15 Jul 2016 16:44:13 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	tremyfr@...il.com
Cc:	andrew@...n.ch, f.fainelli@...il.com, manuel.lauss@...il.com,
	mugunthanvnm@...com, ivecera@...hat.com, xypron.glpk@....de,
	netdev@...r.kernel.org
Subject: Re: [PATCH 2/2] net: ethernet: amd: au1000_eth: use
 phy_ethtool_{get|set}_link_ksettings

From: Philippe Reynes <tremyfr@...il.com>
Date: Fri, 15 Jul 2016 12:05:12 +0200

> There are two generics functions phy_ethtool_{get|set}_link_ksettings,
> so we can use them instead of defining the same code in the driver.
> 
> There was a check on CAP_NET_ADMIN in au1000_set_settings, but this
> check is already done in dev_ethtool, so no need to repeat it before
> calling the generic function.
> 
> Signed-off-by: Philippe Reynes <tremyfr@...il.com>

Applied.