netdev - Re: [PATCH v1 0/3] Add Hisilicon MDIO bus driver and FEMAC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20917223.X0KrqBAbxT@wuerfel>
Date:	Fri, 15 Jul 2016 10:41:07 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Dongpo Li <lidongpo@...ilicon.com>
Cc:	f.fainelli@...il.com, robh+dt@...nel.org, mark.rutland@....com,
	frowand.list@...il.com, davem@...emloft.net, andrew@...n.ch,
	xuejiancheng@...ilicon.com, benjamin.chenhao@...ilicon.com,
	howell.yang@...ilicon.com, netdev@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 0/3] Add Hisilicon MDIO bus driver and FEMAC driver

On Friday, July 15, 2016 4:26:32 PM CEST Dongpo Li wrote:
> This patch set adds a Hisilicon MDIO bus driver and
> a Fast Ethernet MAC(FEMAC) driver.
> We also abstract a general interface "of_phy_get_and_connect"
> for PHY connect. User will have no bother with getting
> "phy-mode" and "phy-handle" any more.
> 
> Changes in v1:
> - Pass private data structure instead of struct mii_bus
>   in MDIO read and write operation.
> - Return the error which devm_clk_get() gives when MDIO probe.
> - Leave the clock unprepared and disabled on error when MDIO probe.
> - Abstract a general interface "of_phy_get_and_connect" for PHY connect.
> - Remove the "_reset" suffixes in "reset-names" property.
> - Enable tx per-packet interrupt when tx fifo full.
> - Remove pointless compatible and add SoC specific compatible.
> - Declare only one clock in MAC dts documentation.
> - Add standard unit suffixes for "phy-reset-delays".
> - Use a smaller NAPI poll weight 16 for our Fast Ethernet MAC.
> - Use phy_ethtool_{get|set}_link_ksettings for ethtool ops.
> - Use phydev from struct net_device in MAC driver.
> 

Looks all good to me now,

Reviewed-by: Arnd Bergmann <arnd@...db.de>

One comment on the submission format: we normally count the initial
submission as "v1", so after [PATCH 0/3], the following version is
[PATCH v2 0/3], not [PATCH v1 0/3].

No need to re-send for this now, and if you end up having to make
other changes, just continue with "v2" for this driver, just follow
the normal scheme if you send another driver.

	Arnd