netdev - Re: [iproute PATCH v4 1/5] tc: m_action: Improve conversion to C99 style initializers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <228202dc-508f-2dd5-136f-bf04b271235c@cumulusnetworks.com>
Date:	Fri, 15 Jul 2016 09:32:41 -0600
From:	David Ahern <dsa@...ulusnetworks.com>
To:	Phil Sutter <phil@....cc>, Stephen Hemminger <shemming@...cade.com>
Cc:	Daniel Borkmann <daniel@...earbox.net>,
	Nicolas Dichtel <nicolas.dichtel@...nd.com>,
	Julien Floret <julien.floret@...nd.com>,
	David Laight <David.Laight@...LAB.COM>, netdev@...r.kernel.org
Subject: Re: [iproute PATCH v4 1/5] tc: m_action: Improve conversion to C99
 style initializers

On 7/13/16 12:47 PM, Phil Sutter wrote:
> This improves my initial change in the following points:
>
> - Flatten embedded struct's initializers.
> - No need to initialize variables to zero as the key feature of C99
>   initializers is to do this implicitly.
> - By relocating the declaration of struct rtattr *tail, it can be
>   initialized at the same time.
>
> Fixes: a0a73b298a579 ("tc: m_action: Use C99 style initializers for struct req")
> Signed-off-by: Phil Sutter <phil@....cc>
> ---
> Changes since v2:
> - Don't drop the "superfluous" comma.
> - Flatten initializers.
> Changes since v1:
> - Created this patch.
> ---
>  tc/m_action.c | 23 +++++++----------------
>  1 file changed, 7 insertions(+), 16 deletions(-)

Acked-by: David Ahern <dsa@...ulusnetworks.com>