netdev - Re: [PATCH net-next] sctp: recvmsg should be able to run even if sock is in closing state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160716.220230.1568654523682522363.davem@davemloft.net>
Date:	Sat, 16 Jul 2016 22:02:30 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	marcelo.leitner@...il.com
Cc:	netdev@...r.kernel.org, nhorman@...driver.com, vyasevich@...il.com,
	linux-sctp@...r.kernel.org, lucien.xin@...il.com
Subject: Re: [PATCH net-next] sctp: recvmsg should be able to run even if
 sock is in closing state

From: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
Date: Fri, 15 Jul 2016 16:38:19 -0300

> Commit d46e416c11c8 missed to update some other places which checked for
> the socket being TCP-style AND Established state, as Closing state has
> some overlapping with the previous understanding of Established.
> 
> Without this fix, one of the effects is that some already queued rx
> messages may not be readable anymore depending on how the association
> teared down, and sending may also not be possible if peer initiated the
> shutdown.
> 
> Also merge two if() blocks into one condition on sctp_sendmsg().
> 
> Cc: Xin Long <lucien.xin@...il.com>
> Fixes: d46e416c11c8 ("sctp: sctp should change socket state when shutdown is received")
> Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>

Applied.