netdev - Re: [PATCH net] et131x: Fix logical vs bitwise check in et131x_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160716.220444.1385583329528724015.davem@davemloft.net>
Date:	Sat, 16 Jul 2016 22:04:44 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	f.fainelli@...il.com
Cc:	netdev@...r.kernel.org, mark.einon@...il.com, andrew@...n.ch,
	a@...table.cc, felipe.balbi@...ux.intel.com, fw@...len.de,
	wuninsu@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] et131x: Fix logical vs bitwise check in
 et131x_tx_timeout()

From: Florian Fainelli <f.fainelli@...il.com>
Date: Fri, 15 Jul 2016 16:40:22 -0700

> We should be using a logical check here instead of a bitwise operation
> to check if the device is closed already in et131x_tx_timeout().
> 
> Reported-by: coverity (CID 146498)
> Fixes: 38df6492eb511 ("et131x: Add PCIe gigabit ethernet driver et131x to drivers/net")
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>

Applied.