lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Sat, 16 Jul 2016 22:15:49 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	richard@...-stearn.demon.co.uk
Cc:	netdev@...r.kernel.org, linux-hams@...r.kernel.org
Subject: Re: [PATCH 0/6]NET:AX25:ROSE Adds device use count, adds trap to
 prevent kernel crash, plus other cleanup


First, this is really a poorly formatted submission.

All of this:

====================
Subject: [PATCH 0/6]NET:AX25:ROSE Adds device use count, adds trap to prevent kernel crash, plus other cleanup
[PATCH 1/6]NET:AX25:ROSE
Adds device use count for core of protocol.
====================

over and over is not what belongs in this "0/6" header postings.

Instead, you're supposed to write paragraphs of prose, explaining to us what
this patch series is doing, how it is doing it, and why it is doing it that way.

Next, the Subject lines should be of the form:

	"[PATCH N/M] ax25: ..."

Note the spaces, and the subsystem prefix is in lowercase letters, and we typically
don't use a cascade of "x: y: z:", it's just pointless.

Also, do not duplicate the Subject line in your commit log messages.

Second of all, all of these new device refcount bumps create a new problem.
You can't just do get and put all over the place.

You also have to have device notifiers that kill all of the ax25/rose
objects that point to the device when someone tries to unregister it.

Powered by blists - more mailing lists