netdev - Re: [PATCH 1/4] Marvell phy: check link status in case of fiber link.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160718153257.GJ19265@lunn.ch>
Date:	Mon, 18 Jul 2016 17:32:57 +0200
From:	Andrew Lunn <andrew@...n.ch>
To:	Charles-Antoine Couret <charles-antoine.couret@...vision.fr>
Cc:	cacouret.renault@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH 1/4] Marvell phy: check link status in case of fiber link.

On Mon, Jul 18, 2016 at 11:03:40AM +0200, Charles-Antoine Couret wrote:

Hi Charles-Antoine

Looking good. Just one nitpick.

>  /* marvell_read_status

You missed changing this name above.

>   *
> - * Generic status code does not detect Fiber correctly!
>   * Description:
>   *   Check the link, then figure out the current state
>   *   by comparing what we advertise with what the link partner
>   *   advertises.  Start by checking the gigabit possibilities,
>   *   then move on to 10/100.
>   */
> -static int marvell_read_status(struct phy_device *phydev)
> +static int marvell_read_status_page(struct phy_device *phydev, int page)

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew