netdev - Re: [PATCH net] bnxt_en: Remove locking around txr->dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACKFLi=cZ4EZ8U2y2R5ZXur9q1_HFFDNpa99i2dhvmoxZSgneA@mail.gmail.com>
Date:	Mon, 18 Jul 2016 13:06:36 -0700
From:	Michael Chan <michael.chan@...adcom.com>
To:	Florian Fainelli <f.fainelli@...il.com>
Cc:	Netdev <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>,
	Jeffrey Huang <huangjw@...adcom.com>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net] bnxt_en: Remove locking around txr->dev_state

On Mon, Jul 18, 2016 at 1:02 PM, Florian Fainelli <f.fainelli@...il.com> wrote:
> txr->dev_state was not consistently manipulated with the acquisition of
> the per-queue lock, after further inspection the lock does not seem
> necessary, either the value is read as BNXT_DEV_STATE_CLOSING or 0.
>
> Reported-by: coverity (CID 1339583)
> Fixes: c0c050c58d840 ("bnxt_en: New Broadcom ethernet driver.")
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>

Thanks Florian.

Acked-by: Michael Chan <michael.chan@...adcom.com>