netdev - Re: [PATCH net] bnxt_en: Fix potential race condition in bnxt_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 18 Jul 2016 04:34:37 -0700
From:	Michael Chan <michael.chan@...adcom.com>
To:	David Miller <davem@...emloft.net>
Cc:	f.fainelli@...il.com, Netdev <netdev@...r.kernel.org>,
	Jeffrey Huang <huangjw@...adcom.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] bnxt_en: Fix potential race condition in bnxt_tx_enable()

On Fri, Jul 15, 2016 at 11:20 PM, David Miller <davem@...emloft.net> wrote:
> From: Florian Fainelli <f.fainelli@...il.com>
> Date: Fri, 15 Jul 2016 16:42:01 -0700
>
>> @@ -4599,7 +4599,9 @@ static void bnxt_tx_enable(struct bnxt *bp)
>>       for (i = 0; i < bp->tx_nr_rings; i++) {
>>               txr = &bp->tx_ring[i];
>>               txq = netdev_get_tx_queue(bp->dev, i);
>> +             __netif_tx_lock(txq, smp_processor_id());
>>               txr->dev_state = 0;
>> +             __netif_tx_unlock(txq);
>
> You're going to have to explain how this could possibly cause a
> problem, because I'm pretty sure it can't.
>
> Either the reader sees 0, or non-zero, in this value.
>
> And adding locking around this assignment does not change that at all.

Florian, I agree with David.  The lock is not needed.  The lock in
bnxt_tx_disable() is also unnecessary and should be removed.  Thanks.