netdev - Re: [PATCH v0 00/10] Convert Netgear WNR854T to devicetree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160719141640.GZ31103@lunn.ch>
Date:	Tue, 19 Jul 2016 16:16:40 +0200
From:	Andrew Lunn <andrew@...n.ch>
To:	Jamie Lentin <jm@...tin.co.uk>,
	Vivien Didelot <vivien.didelot@...oirfairelinux.com>
Cc:	Florian Fainelli <f.fainelli@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v0 00/10] Convert Netgear WNR854T to devicetree

[Reducing the Cc: list a bit to networking people]

> Okay. Frames sent from the port are EDSA-tagged (which isn't exactly
> surprising), but I'm yet to see the switch receive 0xdada frames.
> Even with the net-next branch which uses DSA_TAG_PROTO_EDSA for all
> chip types.
> 
> However, the ethertype is reflecting the port:-
> 
> lan1/5 : ethertype Unknown (0xc028), length 176:
> lan2/7 : ethertype Unknown (0xc038), length 176:
> lan3/0 : ethertype Unknown (0xc000), length 176:
> lan4/1 : ethertype Unknown (0xc008), length 176:
> wan/2  : ethertype Unknown (0xc010), length 176:

O.K, we broke it :-(

The 6185 does not support EDSA, only DSA.

Vivien, this is going to cause us problems. We need two different
dsa_switch_driver structures, one for EDSA capable devices, and one
for those which are not.

Or we do something more radical, like add a driver callback to return
the tagging protocol, rather than hard code it in the structure? We
can then use a capability flag.

    Andrew