netdev - Re: [PATCH] net/sched/sch_htb: clamp xstats tokens to fit into 32-bit int

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160718.224539.1775569403422486926.davem@davemloft.net>
Date:	Mon, 18 Jul 2016 22:45:39 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	khlebnikov@...dex-team.ru
Cc:	netdev@...r.kernel.org, edumazet@...gle.com, jhs@...atatu.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net/sched/sch_htb: clamp xstats tokens to fit into
 32-bit int

From: Konstantin Khlebnikov <khlebnikov@...dex-team.ru>
Date: Sat, 16 Jul 2016 17:08:56 +0300

> In kernel HTB keeps tokens in signed 64-bit in nanoseconds. In netlink
> protocol these values are converted into pshed ticks (64ns for now) and
> truncated to 32-bit. In struct tc_htb_xstats fields "tokens" and "ctokens"
> are declared as unsigned 32-bit but they could be negative thus tool 'tc'
> prints them as signed. Big values loose higher bits and/or become negative.
> 
> This patch clamps tokens in xstat into range from INT_MIN to INT_MAX.
> In this way it's easier to understand what's going on here.
> 
> Signed-off-by: Konstantin Khlebnikov <khlebnikov@...dex-team.ru>

Applied.