netdev - Re: [PATCH] xfrm: fix crash in XFRM_MSG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160719073506.GQ12335@gauss.secunet.com>
Date:	Tue, 19 Jul 2016 09:35:06 +0200
From:	Steffen Klassert <steffen.klassert@...unet.com>
To:	Herbert Xu <herbert@...dor.apana.org.au>
CC:	David Miller <davem@...emloft.net>, <vegard.nossum@...cle.com>,
	<nicolas.dichtel@...nd.com>, <netdev@...r.kernel.org>
Subject: Re: [PATCH] xfrm: fix crash in XFRM_MSG_GETSA netlink handler

On Sun, Jul 10, 2016 at 02:21:13PM +0200, Steffen Klassert wrote:
> On Wed, Jul 06, 2016 at 10:27:29AM +0800, Herbert Xu wrote:
> > On Tue, Jul 05, 2016 at 12:13:03PM -0700, David Miller wrote:
> > > From: Vegard Nossum <vegard.nossum@...cle.com>
> > > Date: Tue,  5 Jul 2016 10:18:08 +0200
> > > 
> > > > If we hit any of the error conditions inside xfrm_dump_sa(), then
> > > > xfrm_state_walk_init() never gets called. However, we still call
> > > > xfrm_state_walk_done() from xfrm_dump_sa_done(), which will crash
> > > > because the state walk was never initialized properly.
> > > > 
> > > > We can fix this by setting cb->args[0] only after we've processed the
> > > > first element and checking this before calling xfrm_state_walk_done().
> > > > 
> > > > Fixes: d3623099d3 ("ipsec: add support of limited SA dump")
> > > > Cc: Nicolas Dichtel <nicolas.dichtel@...nd.com>
> > > > Cc: Steffen Klassert <steffen.klassert@...unet.com>
> > > > Signed-off-by: Vegard Nossum <vegard.nossum@...cle.com>
> > > 
> > > I assume Steffen will pick this up.
> > 
> > I think Steffen said that he is going to be on vacation for two
> > weeks starting this week.
> 
> Right, I'll take care of it as soon as I'm back.

Now applied to the ipsec tree, thanks a lot!