netdev - Re: [PATCH -next] net: ethernet: nb8800: fix error handling of nb8800

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yw1x1t2peu51.fsf@unicorn.mansr.com>
Date:	Tue, 19 Jul 2016 12:37:14 +0100
From:	Måns Rullgård <mans@...sr.com>
To:	Wei Yongjun <weiyj_lk@....com>
Cc:	f.fainelli@...il.com, davem@...emloft.net, tremyfr@...il.com,
	arnd@...db.de, sf84@...oste.net,
	Wei Yongjun <yongjun_wei@...ndmicro.com.cn>,
	netdev@...r.kernel.org
Subject: Re: [PATCH -next] net: ethernet: nb8800: fix error handling of nb8800_probe()

Wei Yongjun <weiyj_lk@....com> writes:

> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
>
> In ops->reset() error handling case, clk_disable_unprepare() is missed
> before return from this function.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>

Acked-by: Mans Rullgard <mans@...sr.com>

> ---
>  drivers/net/ethernet/aurora/nb8800.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/aurora/nb8800.c b/drivers/net/ethernet/aurora/nb8800.c
> index 2dcb8c7..0d4ea92 100644
> --- a/drivers/net/ethernet/aurora/nb8800.c
> +++ b/drivers/net/ethernet/aurora/nb8800.c
> @@ -1419,7 +1419,7 @@ static int nb8800_probe(struct platform_device *pdev)
>  	if (ops && ops->reset) {
>  		ret = ops->reset(dev);
>  		if (ret)
> -			goto err_free_dev;
> +			goto err_disable_clk;
>  	}
>
>  	bus = devm_mdiobus_alloc(&pdev->dev);
>

-- 
Måns Rullgård