netdev - Re: [PATCH v10 00/12] Add driver bpf hook for early packet drop and forwarding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Wed, 20 Jul 2016 12:14:16 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ttoukan.linux@...il.com
Cc:	bblanco@...mgrid.com, netdev@...r.kernel.org, jhs@...atatu.com,
	saeedm@....mellanox.co.il, kafai@...com, brouer@...hat.com,
	as754m@....com, alexei.starovoitov@...il.com, gerlitz.or@...il.com,
	john.fastabend@...il.com, hannes@...essinduktion.org,
	tgraf@...g.ch, tom@...bertland.com, daniel@...earbox.net
Subject: Re: [PATCH v10 00/12] Add driver bpf hook for early packet drop
 and forwarding

From: Tariq Toukan <ttoukan.linux@...il.com>
Date: Wed, 20 Jul 2016 12:18:49 +0300

> 
> On 20/07/2016 8:09 AM, David Miller wrote:
>> From: Brenden Blanco <bblanco@...mgrid.com>
>> Date: Tue, 19 Jul 2016 12:16:45 -0700
>>
>>> This patch set introduces new infrastructure for programmatically
>>> processing packets in the earliest stages of rx, as part of an effort
>>> others are calling eXpress Data Path (XDP) [1]. Start this effort by
>>> introducing a new bpf program type for early packet filtering, before
>>> even an skb has been allocated.
>>>
>>> Extend on this with the ability to modify packet data and send back
>>> out
>>> on the same port.
>> Series applied, thanks.
> 
> Hi Dave,
> 
> The series causes compilation errors in our driver (and warnings).
> Please revert it.

Asking for a revert in such a knee-jerk reaction like this is not
appropriate.

Never ask me to do this.

Why don't you try to figure out what the simple fix is instead?

Meanwhile I've already pushed out the appropriate fix.