netdev - Re: [PATCH net-next v3] cdc_ether: Improve ZTE MF823/831/910 handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160720.145522.1781498396880526212.davem@davemloft.net>
Date:	Wed, 20 Jul 2016 14:55:22 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	kristian.evensen@...il.com
Cc:	oliver@...kum.org, linux-usb@...r.kernel.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v3] cdc_ether: Improve ZTE MF823/831/910
 handling

From: Kristian Evensen <kristian.evensen@...il.com>
Date: Tue, 19 Jul 2016 16:54:11 +0200

> The firmware in several ZTE devices (at least the MF823/831/910
> modems/mifis) use OS fingerprinting to determine which type of device to
> export. In addition, these devices export a REST API which can be used to
> control the type of device. So far, on Linux, the devices have been seen as
> RNDIS or CDC Ether.
> 
> When CDC Ether is used, devices of the same type are, as with RNDIS,
> exported with the same, bogus random MAC address. In addition, the devices
> (at least on all firmware revisions I have found) use the bogus MAC when
> sending traffic routed from external networks. And as a final feature, the
> devices sometimes export the link state incorrectly. There are also
> references online to several other ZTE devices displaying this behavior,
> with several different PIDs and MAC addresses.
> 
> This patch tries to improve the handling of ZTE devices by doing the
> following:

Please fix these warnings and resubmit:

  CC [M]  drivers/net/usb/cdc_ether.o
drivers/net/usb/cdc_ether.c: In function ‘usbnet_cdc_zte_rx_fixup’:
drivers/net/usb/cdc_ether.c:461:5: warning: unused variable ‘buggy_hwaddrs_idx’ [-Wunused-variable]
  u8 buggy_hwaddrs_idx = 0;
     ^
drivers/net/usb/cdc_ether.c:460:5: warning: unused variable ‘num_buggy_hwaddrs’ [-Wunused-variable]
  u8 num_buggy_hwaddrs;
     ^