netdev - Re: [PATCH] bpf: fix implicit declaration of bpf_prog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160720160620.GA76501@ast-mbp.thefacebook.com>
Date:	Wed, 20 Jul 2016 09:06:22 -0700
From:	Alexei Starovoitov <alexei.starovoitov@...il.com>
To:	Brenden Blanco <bblanco@...mgrid.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	Tariq Toukan <ttoukan.linux@...il.com>,
	Daniel Borkmann <daniel@...earbox.net>
Subject: Re: [PATCH] bpf: fix implicit declaration of bpf_prog_add

On Wed, Jul 20, 2016 at 07:55:52AM -0700, Brenden Blanco wrote:
> For the ifndef case of CONFIG_BPF_SYSCALL, an inline version of
> bpf_prog_add needs to exist otherwise the build breaks on some configs.
> 
>  drivers/net/ethernet/mellanox/mlx4/en_netdev.c:2544:10: error: implicit declaration of function 'bpf_prog_add'
>        prog = bpf_prog_add(prog, priv->rx_ring_num - 1);
> 
> The function is introduced in
> 59d3656d5bf50 ("bpf: add bpf_prog_add api for bulk prog refcnt")
> and first used in
> 47f1afdba2b87 ("net/mlx4_en: add support for fast rx drop bpf program").
> 
> Fixes: 47f1afdba2b87 ("net/mlx4_en: add support for fast rx drop bpf program")
> Reported-by: kbuild test robot <fengguang.wu@...el.com>
> Reported-by: Tariq Toukan <ttoukan.linux@...il.com>
> Signed-off-by: Brenden Blanco <bblanco@...mgrid.com>

Acked-by: Alexei Starovoitov <ast@...nel.org>