netdev - Re: [PATCH net] net/mlx5e: Fix del vxlan port command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 20 Jul 2016 19:30:31 +0300
From:	Saeed Mahameed <saeedm@....mellanox.co.il>
To:	Alexei Starovoitov <alexei.starovoitov@...il.com>
Cc:	Saeed Mahameed <saeedm@...lanox.com>,
	"David S. Miller" <davem@...emloft.net>,
	Linux Netdev List <netdev@...r.kernel.org>,
	Matthew Finlay <matt@...lanox.com>
Subject: Re: [PATCH net] net/mlx5e: Fix del vxlan port command

On Wed, Jul 20, 2016 at 7:15 PM, Alexei Starovoitov
<alexei.starovoitov@...il.com> wrote:
> On Wed, Jul 20, 2016 at 05:48:48PM +0300, Saeed Mahameed wrote:
>> mlx5e_vxlan_core_del_port_cmd cleared the wrong address, the address of
>> the pointer of the buffer rather than clearing the buffer itself.
>>
>> This can lead to a serious stack corruption.
>
> The change is fine, but commit log is complete nonsense.
> Nacking to make sure it's adjusted.
> We cannot have such commits in the git history.

That was my hunch too :) , will fix this.