netdev - Re: [Patch net-next 1/2] net_sched: move tc_action into tcf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1ce68bcb-7a73-013c-bdd7-639dce465ea7@mojatatu.com>
Date:	Thu, 21 Jul 2016 03:38:21 -0400
From:	Jamal Hadi Salim <jhs@...atatu.com>
To:	Cong Wang <xiyou.wangcong@...il.com>, netdev@...r.kernel.org
Subject: Re: [Patch net-next 1/2] net_sched: move tc_action into tcf_common

It is an involved change (and i was fond of the container_of()
trickery;)).

Looking at this patch I cant grok some parts - maybe i need to apply it
when i am not in a hurry to see clearly.
Mostly this around things like:
---
const struct tc_action *a
struct tcf_mirred *m = to_mirred(a)
---

Essentially this reduces to
struct tcf_mirred *m = (struct tcf_mirred *)a

How would that work?
Do we still need the void *priv

cheers,
jamal