netdev - Re: [PATCH 1/1] netfilter: udp: Only get 8 bytes header in udp_pkt_to_tuple to keep consistent with tcp_pkt_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160721091027.GE9123@breakpoint.cc>
Date:	Thu, 21 Jul 2016 11:10:27 +0200
From:	Florian Westphal <fw@...len.de>
To:	fgao@...ai8.com
Cc:	pablo@...filter.org, kaber@...sh.net,
	netfilter-devel@...r.kernel.org, netdev@...r.kernel.org,
	gfree.wind@...il.com
Subject: Re: [PATCH 1/1] netfilter: udp: Only get 8 bytes header in
 udp_pkt_to_tuple to keep consistent with tcp_pkt_to_tuple and comments

fgao@...ai8.com <fgao@...ai8.com> wrote:
> From: Gao Feng <fgao@...ai8.com>
> 
> Signed-off-by: Gao Feng <fgao@...ai8.com>
> ---
>  net/netfilter/nf_conntrack_proto_udp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/netfilter/nf_conntrack_proto_udp.c b/net/netfilter/nf_conntrack_proto_udp.c
> index 4fd0405..a886a8a 100644
> --- a/net/netfilter/nf_conntrack_proto_udp.c
> +++ b/net/netfilter/nf_conntrack_proto_udp.c
> @@ -45,7 +45,7 @@ static bool udp_pkt_to_tuple(const struct sk_buff *skb,
>  	struct udphdr _hdr;
>  
>  	/* Actually only need first 8 bytes. */
> -	hp = skb_header_pointer(skb, dataoff, sizeof(_hdr), &_hdr);
> +	hp = skb_header_pointer(skb, dataoff, 8, &_hdr);

This comment is a bit misleading; sizeof(udphdr) is 8 bytes so
this patch has no effect.