netdev - Re: [PATCH net-next v2] net/faraday: Disallow using reversed MAC address from hardware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160722000148.GA5176@gwshan>
Date:	Fri, 22 Jul 2016 10:01:48 +1000
From:	Gavin Shan <gwshan@...ux.vnet.ibm.com>
To:	Andrew Lunn <andrew@...n.ch>
Cc:	Gavin Shan <gwshan@...ux.vnet.ibm.com>, netdev@...r.kernel.org,
	davem@...emloft.net, benh@...nel.crashing.org,
	David.Laight@...LAB.COM
Subject: Re: [PATCH net-next v2] net/faraday: Disallow using reversed MAC
 address from hardware

On Thu, Jul 21, 2016 at 04:01:09PM +0200, Andrew Lunn wrote:
>On Thu, Jul 21, 2016 at 11:42:54AM +1000, Gavin Shan wrote:
>> The initial MAC address is retrieved from hardware if it's not
>> provided by device-tree. The reserved MAC address from hardware
>> will be used if non-reserved MAC address is invalid. It will
>> cause mismatched MAC address seen by hardware and software.
>> 
>> This disallows using the reserved hardware MAC address to avoid
>> the mismatched MAC address seen by hardware and software.
>> 
>> Fixes: 113ce107afe9 ("net/faraday: Read MAC address from chip")
>> Suggested-by: David Laight <David.Laight@...LAB.COM>
>> Suggested-by: Benjamin Herrenschmidt <benh@...nel.crashing.org>
>> Signed-off-by: Gavin Shan <gwshan@...ux.vnet.ibm.com>
>
>Too late now, since it has been accepted, but the subject line says
>reversed, not reserved.
>

Yes, It should be reversed, not reserved in the commit log.

Thanks,
Gavin