netdev - Re: ref count of ib_ipoib.ko not incremented when an ip address is set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160722152318.6a1e5f1a@xeon-e3>
Date:	Fri, 22 Jul 2016 15:23:18 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Nikolay Borisov <kernel@...p.com>
Cc:	netdev@...r.kernel.org,
	"linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
	David Miller <davem@...emloft.net>, sean.hefty@...el.com,
	dledford@...hat.com,
	SiteGround Operations <operations@...eground.com>
Subject: Re: ref count of ib_ipoib.ko not incremented when an ip address is
 set

On Fri, 22 Jul 2016 11:16:02 +0300
Nikolay Borisov <kernel@...p.com> wrote:

> Hello, 
> 
> I accidentally saw that even having an ip address on an 
> ipoib interface doesn't increment the usage count of the 
> ib_ipoib.ko module: 
> 
> ip a l dev ib0
> 14: ib0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 65520 qdisc pfifo_fast state UP qlen 256
>     link/infiniband 80:00:02:d4:fe:80:00:00:00:00:00:00:e4:1d:2d:03:00:00:f8:31 brd 00:ff:ff:ff:ff:12:40:1b:ff:ff:00:00:00:00:00:00:ff:ff:ff:ff
>     inet 172.16.0.150/24 brd 172.16.0.255 scope global ib0
>        valid_lft forever preferred_lft forever
> 
> lsmod | grep ib_ipoib
> ib_ipoib               79026  0 
> ib_cm                  34144  3 ib_ipoib,ib_ucm,rdma_cm
> ib_sa                  26598  5 ib_ipoib,rdma_ucm,rdma_cm,ib_cm,mlx4_ib
> ib_core                97620  10 ib_ipoib,ib_ucm,ib_uverbs,rdma_cm,iw_cm,ib_umad,ib_cm,mlx4_ib,ib_sa,ib_mad
> ipv6                  374806  259 ib_ipoib,rdma_cm,ib_addr,[permanent]
> 
> 
> In this case I can rmmod ib_ipoib.ko which would remove, 
> but in practice I've observed that when an ip address is set
> the underlying module providing the interface usually gets
> its ref count incremented. Is this normal or is a 
> refcount increment is amiss?
> 
> Regards, 
> Nikolay 

Network devices are always supposed to have module refcount of zero
and they can be rmmod'd safely.  This was an intentional design decision
all the way back to 2.5 version.