netdev - Re: [PATCH 1/1] lvs: Use IS_ERR_OR_NULL(svc) instead of IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.11.1607220757100.1764@ja.home.ssi.bg>
Date:	Fri, 22 Jul 2016 08:04:50 +0300 (EEST)
From:	Julian Anastasov <ja@....bg>
To:	Gao Feng <fgao@...ai8.com.aqb.so>
cc:	wensong@...ux-vs.org, horms@...ge.net.au, netdev@...r.kernel.org,
	lvs-devel@...r.kernel.org, gfree.wind@...il.com
Subject: Re: [PATCH 1/1] lvs: Use IS_ERR_OR_NULL(svc) instead of IS_ERR(svc)
 || svc == NULL


	Hello,

On Fri, 22 Jul 2016, fgao@...ai8.com.aqb.so wrote:

> From: Gao Feng <fgao@...ai8.com>
> 
> This minor refactoring does not change the logic of function
> ip_vs_genl_dump_dests.
> 
> Signed-off-by: Gao Feng <fgao@...ai8.com>

	Looks good to me,

Acked-by: Julian Anastasov <ja@....bg>

	If there is a next version you can change above
"lvs" with "ipvs" in the Subject, this is the name we use
for the kernel part.

> ---
>  v1: Initial patch
> 
>  net/netfilter/ipvs/ip_vs_ctl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/netfilter/ipvs/ip_vs_ctl.c b/net/netfilter/ipvs/ip_vs_ctl.c
> index c3c809b..6dc86cc 100644
> --- a/net/netfilter/ipvs/ip_vs_ctl.c
> +++ b/net/netfilter/ipvs/ip_vs_ctl.c
> @@ -3267,7 +3267,7 @@ static int ip_vs_genl_dump_dests(struct sk_buff *skb,
>  
>  
>  	svc = ip_vs_genl_find_service(ipvs, attrs[IPVS_CMD_ATTR_SERVICE]);
> -	if (IS_ERR(svc) || svc == NULL)
> +	if (IS_ERR_OR_NULL(svc))
>  		goto out_err;
>  
>  	/* Dump the destinations */
> -- 
> 1.9.1

Regards

--
Julian Anastasov <ja@....bg>