netdev - Re: [Patch net-next v2 1/2] net_sched: move tc_action into tcf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a3955281-054c-03e2-15b0-c09f6d2b93d2@mojatatu.com>
Date:	Tue, 26 Jul 2016 10:00:12 -0400
From:	Jamal Hadi Salim <jhs@...atatu.com>
To:	Cong Wang <xiyou.wangcong@...il.com>, netdev@...r.kernel.org
Subject: Re: [Patch net-next v2 1/2] net_sched: move tc_action into tcf_common

On 16-07-25 07:09 PM, Cong Wang wrote:
> struct tc_action is confusing, currently we use it for two purposes:
> 1) Pass in arguments and carry out results from helper functions
> 2) A generic representation for tc actions
>
> The first one is error-prone, since we need to make sure we don't
> miss anything. This patch aims to get rid of this use, by moving
> tc_action into tcf_common, so that they are allocated together
> in hashtable and can be cast'ed easily.
>
> And together with the following patch, we could really make
> tc_action a generic representation for all tc actions and each
> type of action can inherit from it.
>
> Cc: Jamal Hadi Salim <jhs@...atatu.com>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>


Cong - i need to stare at this longer than cursory
to give feedback. I apologize,
I am in travel mode but will get back to you.

cheers,
jamal